[ gpsdrive ] Build issues

[Hamish]

Chris:
> This time gpsdrive is not playing nice. svn rev 2144
> using cmake -DWITH_MAPNIK=OFF .. and meeting all needed dependencies
> according to cmake I get the following error upon building (also
> turned off friendserver as I don't use it)
....
> Linking C executable gmapview
> CMakeFiles/gmapview.dir/gmapview.o: In function `expose':
> gmapview.c:(.text+0xdc): undefined reference to `drawmarkers'
> collect2: ld returned 1 exit status
....
> Any suggestions? 

Just a guess, did you set GDAL=YES somewhere?
I think perhaps that code has not kept up to date with function name
changes in the core??
If GDAL was set to be on in DefineOptions.cmake or with -DWITH.. command
line option you'll need to turn it off and remove build/CMakeCache.txt

 
> Also I noticed the following behavior with setting waypoints. There
> appears to be a limit on the length of the name and it appears to be
> controlled by the form generated when you press find.
> The limit appears to be 20 characters.

yes. see src/waypoint.c lines 318 and 715.
actually the field length is already 40 (including 1 for the trailing
null and remembering that counting starts from 0), but is cropped down
to 20 for reasons unknown to me.

savewaypoints() would also need to be adjusted (%-22s to %-32s etc)

FWIW this 20 char limit is now documented in the man page.


> A request. Would it be possible to increase the size of the appropriate
> field in the form to approx 30 characters?

fine with me, but I hesitate to do it as I am not sure about side effects.

 
> Tested on 2.10pre4. While I know this is outdated my svn build is giving
> me issues..:) Perhaps someone could check to see if the behavior is
> consistant in trunk.

It is.


Hamish