[ gpsdrive ] WITH_MYDEBUG

[info at 4x4falcon.com]

Forgot to say also that it's the first time I've uploaded directly to svn
so I used a small non intrusive file to make sure that I had it right
before uploading anything really important.

Cheers
Ross

> Hi,
>
> Revision: 2260
>   trunk/DefineOptions.cmake
> ...
> +option(WITH_MYDEBUG "Build with debug -D support" OFF)
> ...
>
> what's the point of this? AFAICT there is no #ifdef MYDEBUG in the
> code, so adding -DMYDEBUG has no effect. (nor permanent #ifdef DEBUG
> for that matter)
>
> Also I would think that "WITH_*" would usually be reserved for "with
> support for some <packagename>, ie not some general preproc flag.
> so FRIENDSD and NAVIGATE, (+KISMET ?) would not get WITH_.
> ??
>
> and probably not bother with setting -DKISMET until that actually exists
> in the code.
>
>
> just trying to reduce the noise,
> Hamish
> _______________________________________________
> GPSdrive mailing list
> GPSdrive at lists.gpsdrivers.org
> http://lists.gpsdrivers.org/mailman/listinfo/gpsdrive
>